feature: allow resources to be added from a map directly. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here - add a basic test for AddResourceFromMap
santhosh-tekuri
requested changes
Oct 17, 2023
added 2 commits
October 17, 2023 13:45
- adjust AddResource to use AddResource JSON
- use `interface{}` instead of `any`
- simplify test to avoid draft version issues
- tweak test to just evaluate based on `type` property
santhosh-tekuri
requested changes
Oct 18, 2023
- remove testfile I added - typos - update comments
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 89.21% 89.11% -0.11%
==========================================
Files 10 10
Lines 2651 2654 +3
==========================================
Hits 2365 2365
- Misses 237 239 +2
- Partials 49 50 +1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to add a
resourceto the compiler that was already loaded and unmarshal'ed elsewhere. In my use-case it helps me from needing to re-marshal a schema I already loaded before being able to add it to thejsonschemacompiler.